Arrow Encoding for LocalDate and LocalTime #5446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
barrage
core
niloc132
previously approved these changes
May 2, 2024
rcaudy
reviewed
May 2, 2024
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Show resolved
Hide resolved
...rrage/src/main/java/io/deephaven/extensions/barrage/chunk/CharChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
May 3, 2024
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java
Outdated
Show resolved
Hide resolved
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java
Show resolved
Hide resolved
rcaudy
reviewed
May 3, 2024
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
May 3, 2024
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Show resolved
Hide resolved
jmao-denver
reviewed
May 3, 2024
rcaudy
previously approved these changes
May 3, 2024
jmao-denver
reviewed
May 3, 2024
Comment on lines
-109
to
-110
| pa.date32(), | ||
| pa.timestamp('ns', tz='MST'), |
There was a problem hiding this comment.
It looks like that we don't support pa.timestamp(ns) with a tz, what about just no tz or tz=utc? If we flatly don't support pa.timestamp, maybe we should remove the 'java.time.Instant' mapping?
There was a problem hiding this comment.
Actually the test might be passing now. I suspect the test isn't looking at the time zones. I do think that the data is correct; the timezone is just like a display that applies to all elements. Instant's aren't in a particular time zone in general. Locally I only get lfs and postgres failures; so... we'll find out soon.
rcaudy
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4823.
Fixes #5265.