Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.form Necessity Indicator #924

Open
ethanalvizo opened this issue Oct 4, 2024 · 0 comments
Open

ui.form Necessity Indicator #924

ethanalvizo opened this issue Oct 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ethanalvizo
Copy link
Contributor

Description
The necessity_indicator prop for ui.form doesn't seem to work. Need to define it in the form fields themselves to switch between using an icon or label to denote required fields (ie. ui.text_field(name="name", label="Name", is_required=True, necessity_indicator="label"))

Steps to reproduce

  1. Run the following code
from deephaven import ui


@ui.component
def ui_form_indicator():
    def icon_indicator():
        return ui.form(
            ui.text_field(name="name", label="Name", is_required=True),
            ui.text_field(name="age", label="Age"),
            is_required=True,
        )
    def label_indicator():
        return ui.form(
            ui.text_field(name="name", label="Name", is_required=True),
            ui.text_field(name="age", label="Age"),
            is_required=True,
            necessity_indicator="label",
        )
    
    return [icon_indicator(), label_indicator()]


my_form_required = ui_form_indicator()

Expected results
image

Actual results
image

Additional details and attachments

Versions
Engine Version: 0.37.0-SNAPSHOT
Web UI Version: 0.95.0
Java Version: 21.0.4
Barrage Version: 0.6.0
Browser Name: Microsoft Edge 129
OS Name: macOS 10.15.7
@deephaven/js-plugin-plotly-express: 0.11.2
@deephaven/js-plugin-matplotlib: 0.5.0
@deephaven/js-plugin-ui: 0.21.0

  • Engine Version: ...
  • Web UI Version: ...
  • Java Version: ...
  • Barrage Version: ...
  • OS: ...
  • Browser: ...
  • Docker: ...
@ethanalvizo ethanalvizo added bug Something isn't working triage labels Oct 4, 2024
@vbabich vbabich added this to the October 2024 milestone Oct 8, 2024
@vbabich vbabich removed the triage label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants