-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Display workerName and processInfoId in the console status bar #1173
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 44.21% 44.26% +0.05%
==========================================
Files 449 450 +1
Lines 33449 33480 +31
Branches 8409 8420 +11
==========================================
+ Hits 14789 14820 +31
Misses 18610 18610
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
// TODO: checking just the id should be enough, can probably drop the response message check? | ||
if (data?.id !== id || data?.message !== response) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I think you're right, if we just look at the id
, we don't need to bother looking at response
, and then the signature can just be requestParentResponse(request, timeout)
...
Thinking about this a bit further, there's basically three types of messages we can send:
request
: Something we expect aresponse
forresponse
: Responding to arequest
notify
: Sending a message we do not expect a response for
Perhaps we should do that instead... or even just have those as the three different message types...io.deephaven.message.Request
,io.deephaven.message.Response
, andio.deephaven.message.Notify
, and then the payload itself has the details...
I'm just trying to think how we'll want to extend this later for multi-window messaging/embedding in iframes. Let's discuss later today.
897c772
to
6e54a57
Compare
Resolved conflict in |
5307025
to
43a3630
Compare
Get optional workerName and processInfoId along with the login options response from the DHE host, display in the console status bar.