Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-14581 Fixed generic selector types #1199

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Apr 3, 2023

Supports enterprise DH-14581

Updated redux selectors to properly derive return types from generic input types.

fixes #1197

@bmingles bmingles marked this pull request as ready for review April 3, 2023 22:18
@bmingles bmingles requested a review from mattrunyon April 3, 2023 22:19
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1199 (1893ac2) into main (f39100a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1199   +/-   ##
=======================================
  Coverage   44.20%   44.20%           
=======================================
  Files         448      448           
  Lines       33437    33437           
  Branches     8404     8404           
=======================================
  Hits        14781    14781           
  Misses      18606    18606           
  Partials       50       50           
Flag Coverage Δ
unit 44.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

packages/redux/src/selectors.ts Outdated Show resolved Hide resolved
packages/redux/src/selectors.ts Outdated Show resolved Hide resolved
@bmingles bmingles requested a review from mattrunyon April 4, 2023 17:03
@bmingles bmingles merged commit de9b751 into deephaven:main Apr 4, 2023
@bmingles bmingles deleted the 1197-redux-types branch April 4, 2023 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
@bmingles bmingles changed the title fix: Fixed generic selector types fix: DH-14581 Fixed generic selector types Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DH-14581: Fix Redux Generic Types in @deephaven/redux
2 participants