-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: De-globalize utils, formatters, linker #1278
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
+ Coverage 45.43% 45.46% +0.02%
==========================================
Files 502 503 +1
Lines 34764 34799 +35
Branches 8679 8682 +3
==========================================
+ Hits 15794 15820 +26
- Misses 18919 18928 +9
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/dashboard-core-plugins/src/panels/DropdownFilterPanel.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard-core-plugins/src/panels/DropdownFilterPanel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to update the breaking change list.
Updated breaking changes list, fixed wrong |
jsapi-utils
package. Update all dependent packages.BREAKING CHANGE:
Formatter
requires the JSAPI instance as the first argument.DateTimeColumnFormatter
,DecimalColumnFormatter
,IntegerColumnFormatter
,TableColumnFormatter
: static methodisValid
and constructor require the JSAPI instance in the first argument.Chart
requires the JSAPI instance passed in the new propdh
.WidgetUtils
: methodscreateChartModel
,createGridModel
methods require the JSAPI instance passed in the first argument.DateTimeOptions
,TableInput
,useViewportData
have to be wrapped inApiContext.Provider
passing the JSAPI instance.SettingsUtils
: methodsisValidFormat
andisFormatRuleValidForSave
require the JSAPI instance passed in the first argument.SessionUtils
: methodscreateConnection
,createCoreClient
require the JSAPI instance passed in the first argument.TableUtils
static methodsapplyCustomColumns
,applyFilter
,applyNeverFilter
,applySort
converted to instance methods.DropdownFilterPanel
,Linker
now get the JSAPI instance from redux store.DecimalFormatContextMenu.getOptions
,IntegerFormatContextMenu.getOptions
now require the JSAPI instance in the first argument.