Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panels menu should only open downwards #1340

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

dsmmcken
Copy link
Contributor

Noticed it would shift left sometimes if window is really short. Only allow it to open downwards.

@dsmmcken dsmmcken requested a review from vbabich May 31, 2023 20:11
@dsmmcken dsmmcken self-assigned this May 31, 2023
@dsmmcken dsmmcken removed the request for review from vbabich May 31, 2023 20:11
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1340 (080ace0) into main (9ecbf52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1340   +/-   ##
=======================================
  Coverage   45.95%   45.95%           
=======================================
  Files         493      493           
  Lines       34414    34414           
  Branches     8582     8582           
=======================================
  Hits        15814    15814           
  Misses      18549    18549           
  Partials       51       51           
Flag Coverage Δ
unit 45.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/code-studio/src/main/AppMainContainer.tsx 34.58% <ø> (ø)

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You marked this feat, should be fix

@dsmmcken dsmmcken changed the title feat: panels menu should only open downwards fix: panels menu should only open downwards Jun 1, 2023
@dsmmcken dsmmcken requested a review from mofojed June 1, 2023 18:07
@mofojed mofojed merged commit a25be7f into main Jun 2, 2023
@mofojed mofojed deleted the dmckenzie_prevent_left branch June 2, 2023 13:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants