Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableUtils DateWrapper test logic is incorrect on first day of month #1341

Closed
ethanalvizo opened this issue Jun 1, 2023 · 0 comments · Fixed by #1342
Closed

TableUtils DateWrapper test logic is incorrect on first day of month #1341

ethanalvizo opened this issue Jun 1, 2023 · 0 comments · Fixed by #1342
Labels
bug Something isn't working triage Issue requires triage

Comments

@ethanalvizo
Copy link
Contributor

Description
TableUtils DateWrapper test logic is wrong on first/last day of month.

Steps to reproduce
Run the TableUtils.test.ts file and the 'should return a DateWrapper object if columnType is date' unit test will fail

Expected results
Yesterday date range is returned

Actual results
Yesterday date was returning as NaN

Additional details and attachments
Same issue as #1335
@ethanalvizo ethanalvizo added bug Something isn't working triage Issue requires triage labels Jun 1, 2023
@ethanalvizo ethanalvizo mentioned this issue Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: DateWrapper fails on first day of month ethanalvizo/web-client-ui
1 participant
@ethanalvizo