Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DH-14538: Export InputEditor and added options #1398

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Jul 5, 2023

  • Exporting InputEditor from @deephaven/iris-grid
  • Added optional properties className and placeholder

resolves #1397

Supporting DH-14538

@bmingles bmingles requested a review from mofojed July 5, 2023 23:13
@bmingles bmingles changed the title feat: Export InputEditor and added options feat: DH-14538: Export InputEditor and added options Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1398 (3364754) into main (c76730f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   45.59%   45.59%   -0.01%     
==========================================
  Files         506      506              
  Lines       34976    34997      +21     
  Branches     8738     8749      +11     
==========================================
+ Hits        15947    15956       +9     
- Misses      18978    18990      +12     
  Partials       51       51              
Flag Coverage Δ
unit 45.59% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/iris-grid/src/sidebar/CustomColumnInput.tsx 100.00% <ø> (ø)
packages/iris-grid/src/sidebar/InputEditor.tsx 93.44% <100.00%> (ø)

... and 7 files with indirect coverage changes

@bmingles bmingles requested review from mofojed July 6, 2023 14:42
@mofojed mofojed merged commit 405f42f into deephaven:main Jul 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
@bmingles bmingles deleted the 1397-export-input-editor branch August 31, 2023 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DH-14538: Export InputEditor
2 participants