Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve table saver to always use the correct service worker #1515

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Sep 13, 2023

Fixes #766

BREAKING CHANGE: TableSaver now expects the service worker to send it a complete URL for download instead of just a file name. DHE will need to adjust its serviceWorker.js to incorporate the same changes from this PR.

@mattrunyon mattrunyon requested a review from mofojed September 13, 2023 21:31
@mattrunyon mattrunyon self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 9.09% and project coverage change: +0.65% 🎉

Comparison is base (848fef4) 45.77% compared to head (817cf30) 46.43%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
+ Coverage   45.77%   46.43%   +0.65%     
==========================================
  Files         518      558      +40     
  Lines       35177    35701     +524     
  Branches     8813     8912      +99     
==========================================
+ Hits        16103    16576     +473     
- Misses      19023    19075      +52     
+ Partials       51       50       -1     
Flag Coverage Δ
unit 46.43% <9.09%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/iris-grid/src/sidebar/TableSaver.tsx 11.50% <0.00%> (-0.25%) ⬇️
...ages/code-studio/src/DownloadServiceWorkerUtils.ts 11.11% <16.66%> (+4.44%) ⬆️

... and 85 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon merged commit 2488e52 into deephaven:main Sep 14, 2023
@mattrunyon mattrunyon deleted the table-saver-improvement branch September 14, 2023 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ServiceWorkerUtils to always get the correct service worker for the given PUBLIC_URL
2 participants