fix: Copy did not work from embedded iframes #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Sep 20, 2023
•
mofojed
commented
- embedded iframes require the 'clipboard-write' permission to copy in Chrome. Added note to the README
- Display an error correctly if the copy doesn't succeed, and added unit test
- Fixed context menu as well - default menu handler did not return an array as it should've
- Tested in Firefox and Chrome on Linux
- Fixes Copy does not work from iframe embedded grids #1527
- embedded iframes require the 'clipboard-write' permission to copy in Chrome. Added note to the README - Display an error correctly if the copy doesn't succeed, and added unit test - Fixed context menu as well - default menu handler did not return an array as it should've
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
=======================================
Coverage 46.42% 46.43%
=======================================
Files 558 556 -2
Lines 35714 35715 +1
Branches 8916 8916
=======================================
+ Hits 16582 16584 +2
+ Misses 19082 19081 -1
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mattrunyon
requested changes
Sep 20, 2023
Co-authored-by: Matthew Runyon <mattrunyonstuff@gmail.com>
Co-authored-by: Matthew Runyon <mattrunyonstuff@gmail.com>
mattrunyon
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.