Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prompt for resetting layout #1552

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

bmingles
Copy link
Contributor

User is not prompted to confirm when using the "reset layout" feature.

  • With unsaved notebook changes, prompt title will be "Reset layout and discard unsaved changes"
  • With open notebooks that are saved or no open notebooks, prompt title will be "Reset Layout"
  • If user clicks "Reset", layout will be reset. Unsaved notebook changes will be lost
  • If user clicks "Cancel", layout will not be reset and notebooks remain open

fixes #1250

@bmingles bmingles requested review from mattrunyon, mofojed and dsmmcken and removed request for mofojed September 27, 2023 16:01
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (49723ec) 46.41% compared to head (ece22b4) 46.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1552      +/-   ##
==========================================
- Coverage   46.41%   46.37%   -0.04%     
==========================================
  Files         564      564              
  Lines       35765    35757       -8     
  Branches     8946     8952       +6     
==========================================
- Hits        16599    16583      -16     
- Misses      19116    19122       +6     
- Partials       50       52       +2     
Flag Coverage Δ
unit 46.37% <41.17%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ashboard-core-plugins/src/panels/NotebookPanel.tsx 2.33% <100.00%> (+0.76%) ⬆️
packages/code-studio/src/main/AppMainContainer.tsx 31.15% <23.07%> (-5.98%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles force-pushed the 1250-refresh-layout-prompt branch from 046279f to ece22b4 Compare September 27, 2023 22:02
Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Want @dsmmcken to confirm the wording is what he wants

tests/golden-layout.spec.ts Show resolved Hide resolved
tests/golden-layout.spec.ts Show resolved Hide resolved
@bmingles
Copy link
Contributor Author

Code looks good. Want @dsmmcken to confirm the wording is what he wants

Don actually gave me the text.

@bmingles bmingles requested a review from mattrunyon September 28, 2023 18:51
@bmingles bmingles merged commit a273e64 into deephaven:main Sep 28, 2023
@bmingles bmingles deleted the 1250-refresh-layout-prompt branch September 28, 2023 20:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt to save or discard when refreshing layout in IDE
2 participants