Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: web-client-ui changes required for deephaven.ui #1567

Merged
merged 13 commits into from
Oct 17, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Oct 10, 2023

  • Add some more shared packages to the remote-component.config.ts
    • Now plugins can externalize these packages in their build process, and share the same instance
  • Add Chart handling of model update
  • Add some more externalized packages
  • Add max-old-space-size flag to embed-chart
    • Noticed it was missing, and was causing a build issue with these changes

@mofojed mofojed requested a review from mattrunyon October 10, 2023 20:46
@mofojed mofojed self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (ed8f4b7) 46.45% compared to head (092a831) 46.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
- Coverage   46.45%   46.44%   -0.01%     
==========================================
  Files         572      572              
  Lines       36079    36081       +2     
  Branches     9034     9035       +1     
==========================================
  Hits        16759    16759              
- Misses      19268    19270       +2     
  Partials       52       52              
Flag Coverage Δ
unit 46.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/app-utils/src/plugins/remote-component.config.ts 100.00% <ø> (ø)
packages/chart/src/Chart.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/jsapi-types/src/dh.types.ts Show resolved Hide resolved
packages/jsapi-types/src/dh.types.ts Outdated Show resolved Hide resolved
packages/jsapi-types/src/dh.types.ts Show resolved Hide resolved
packages/golden-layout/scss/goldenlayout-dark-theme.scss Outdated Show resolved Hide resolved
@mofojed mofojed requested a review from mattrunyon October 16, 2023 15:34
package.json Outdated Show resolved Hide resolved
mofojed and others added 13 commits October 17, 2023 14:15
- Needed for chart plugins to work
- Now styles Spectrum components more or less correctly
- Instead of building apps in parallel build at the same time
- Currently getting an OoM error when building in GitHub publish alpha action
- It was only in code-studio and embed-grid for some reason
- Brian will be implementing this with his changes
Co-authored-by: Matthew Runyon <mattrunyonstuff@gmail.com>
- Will also have a follow up ticket to use the automatically generated types
@mofojed mofojed force-pushed the ui-plugin-prototype-no-spectrum branch from e22621e to 092a831 Compare October 17, 2023 18:15
@mofojed mofojed merged commit 94ab25c into deephaven:main Oct 17, 2023
5 checks passed
@mofojed mofojed deleted the ui-plugin-prototype-no-spectrum branch October 17, 2023 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants