Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply theme accent color scale and other small tweaks #1768

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Feb 1, 2024

  • accent-100-1400 wasn't actually applied to spectrum, only actually matters in a few components (like checkboxes in lists), as most used other derived variables
  • enable stylelint on css files
  • change item list selected border color to match iris-grid selected border color (e2e item-list-selected-border change)
  • manually override spectrum selected border color in lists and tables to not be hardcoded as blue, instead use accent
  • adjusted inactive bg color in light theme
  • fix mitre gaps in file list and command history list now that border is more visible
    fixes small mitre gaps:
    image_360

- accent-100-1400 wasn't actually applied to spectrum, only actually matters in a few components (like checkboxes in lists), as most used other derived variables
- enable stylelint on css files
- change item list selected border color to match iris-grid selected border color
- manually override selection border in spectrum lists and tables to not be hardcoded as blue and use accent
- adjusted inactive bg color in light theme
- fix mitre gaps in file list and command history list now that border is more visible
@dsmmcken dsmmcken changed the title fix: apply theme accent color scale fix: apply theme accent color scale and other small tweaks Feb 1, 2024
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the mitre gaps and looks good. Verified that outlined button is now themed properly in styleguide

@dsmmcken dsmmcken merged commit 1e631a4 into main Feb 2, 2024
9 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_themes_accent_fix branch February 2, 2024 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
@dsmmcken dsmmcken self-assigned this Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants