Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Made some plugin types generic #1769

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Feb 1, 2024

I missed making WidgetPanelProps generic in the last PR which is needed to version bump plotly express.
resolves #1759

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e6dd3e1) 46.06% compared to head (e0474e6) 46.06%.

Files Patch % Lines
...ges/dashboard-core-plugins/src/GridPanelPlugin.tsx 0.00% 2 Missing ⚠️
...s/dashboard-core-plugins/src/PandasPanelPlugin.tsx 0.00% 2 Missing ⚠️
...es/dashboard-core-plugins/src/ChartPanelPlugin.tsx 0.00% 1 Missing ⚠️
.../dashboard-core-plugins/src/PandasWidgetPlugin.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1769   +/-   ##
=======================================
  Coverage   46.06%   46.06%           
=======================================
  Files         626      626           
  Lines       37596    37596           
  Branches     9460     9460           
=======================================
  Hits        17319    17319           
  Misses      20222    20222           
  Partials       55       55           
Flag Coverage Δ
unit 46.06% <25.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles requested a review from mofojed February 2, 2024 00:04
@bmingles bmingles merged commit ac40c6f into deephaven:main Feb 2, 2024
6 checks passed
@bmingles bmingles deleted the 1759-widget-component-props branch February 2, 2024 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WidgetPlugin type should be generic
2 participants