Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle empty/null rendering #1778

Merged
merged 2 commits into from
Feb 14, 2024
Merged

feat: toggle empty/null rendering #1778

merged 2 commits into from
Feb 14, 2024

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 commented Feb 7, 2024

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (2cd46ce) 46.10% compared to head (b0031bc) 46.05%.
Report is 12 commits behind head on main.

Files Patch % Lines
...e-studio/src/settings/FormattingSectionContent.tsx 28.57% 10 Missing ⚠️
packages/iris-grid/src/IrisGrid.tsx 72.72% 3 Missing ⚠️
...ckages/iris-grid/src/IrisGridTableModelTemplate.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
- Coverage   46.10%   46.05%   -0.05%     
==========================================
  Files         627      628       +1     
  Lines       37622    37812     +190     
  Branches     9470     9526      +56     
==========================================
+ Hits        17345    17416      +71     
- Misses      20222    20342     +120     
+ Partials       55       54       -1     
Flag Coverage Δ
unit 46.05% <53.12%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusteven815 wusteven815 self-assigned this Feb 13, 2024
@wusteven815 wusteven815 marked this pull request as ready for review February 13, 2024 18:34
@wusteven815 wusteven815 requested a review from mofojed February 13, 2024 18:34
@wusteven815 wusteven815 linked an issue Feb 13, 2024 that may be closed by this pull request
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also tested to make sure that the props were read correctly when specified in deephaven.prop. By default the file is in ~/.config/deephaven/deephaven.prop, and I specified the showEmptyStrings and showNullStrings props by adding the following:

showEmptyStrings=true
showNullStrings=true

client.configuration.list=java.version,deephaven.version,barrage.version,showEmptyStrings,showNullStrings

User was still able to override the setting, which is expected.

@wusteven815 wusteven815 merged commit ae94f1b into deephaven:main Feb 14, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@wusteven815 wusteven815 deleted the feat-1646-string-formatting branch February 20, 2024 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add formatting option to disable empty/null rendering in strings
2 participants