fix: keep active cell selection in first column from going offscreen #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change cell input to not go off edge - makes activeCellSelectionBorderWidth a theme variable, so it can be shared with js and css - change canvas active cell outline to only stick to edge if at left edge of screen, not in any column - re-style active cell input to match latest input variables - change outline of input to use selection border color
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1823 +/- ##
=======================================
Coverage 46.11% 46.11%
=======================================
Files 628 628
Lines 37822 37826 +4
Branches 9529 9532 +3
=======================================
+ Hits 17440 17443 +3
- Misses 20328 20329 +1
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vbabich
approved these changes
Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
active cell input in the first column fully onscreen, before:
after:
cell selected but not active, and partially scrolled offscreen, before:
after:
