Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spectrum textfield validation icon position with set content-box #1825

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Feb 22, 2024

Moves a DHE fix to DHC.

fixes text field spectrum validation icon position:
image

BREAKING CHANGE: the duplicate spectrum-Textfield-validationIcon css in DHE should be removed

Moves a DHE fix to DHC.

BREAKING CHANGE: the duplicate `spectrum-Textfield-validationIcon` css in DHE should be removed
@dsmmcken
Copy link
Contributor Author

feels like a bit of an abuse of breaking change, but not sure how else to flag that the DHE code can be removed when this is merged to DHE.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.11%. Comparing base (677e4c5) to head (6c01feb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1825   +/-   ##
=======================================
  Coverage   46.11%   46.11%           
=======================================
  Files         628      628           
  Lines       37822    37822           
  Branches     9529     9529           
=======================================
  Hits        17440    17440           
  Misses      20328    20328           
  Partials       54       54           
Flag Coverage Δ
unit 46.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like e2e tests need to be updated

@dsmmcken
Copy link
Contributor Author

Flaky test failure, re-ran and it passed.

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified that the icon is positioned correctly in the styleguide y setting validationState="invalid"

@dsmmcken dsmmcken merged commit 8d95212 into main Feb 23, 2024
6 checks passed
@dsmmcken dsmmcken deleted the dmckenzie_spectrum_text_validation branch February 23, 2024 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants