Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re-export Spectrum components + prop types #1880

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

bmingles
Copy link
Contributor

Re-export most of the React Spectrum components listed in the docs. This excludes

  • TableView - likely want our grid to replace this at some point
  • Components we have already wrapped or have components with the same names
  • Beta components

resolves #1852

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.14%. Comparing base (65db969) to head (96353a2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1880   +/-   ##
=======================================
  Coverage   46.14%   46.14%           
=======================================
  Files         636      636           
  Lines       38072    38072           
  Branches     9628     9628           
=======================================
  Hits        17570    17570           
  Misses      20449    20449           
  Partials       53       53           
Flag Coverage Δ
unit 46.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to complain about exposing some of them like logic button because it's not one we would ever use. However, that said exposing to dh.ui is fine and we want it wrapped. So carry on.

@bmingles bmingles merged commit 4783092 into deephaven:main Mar 19, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
@bmingles bmingles deleted the 1852-reexport-spectrum branch March 19, 2024 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-export spectrum components from @deephaven/components
2 participants