Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change autoclosing bracket behavior to beforeWhitespace #1905

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

mattrunyon
Copy link
Collaborator

Checked enterprise and we don't call editor.create anywhere there. We should really centralize these in MonacoUtils with a createEditor or something, but not doing that here.

@mattrunyon mattrunyon requested a review from mofojed March 26, 2024 22:27
@mattrunyon mattrunyon self-assigned this Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.11%. Comparing base (b49b506) to head (531acad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1905   +/-   ##
=======================================
  Coverage   46.11%   46.11%           
=======================================
  Files         637      637           
  Lines       38054    38054           
  Branches     9620     9620           
=======================================
  Hits        17549    17549           
  Misses      20452    20452           
  Partials       53       53           
Flag Coverage Δ
unit 46.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I'd probably centralize with a default settings wrapper or something; the editors do have a couple different options between them, though yes a lot of the settings are universal.

@mattrunyon mattrunyon merged commit 80207f4 into deephaven:main Mar 27, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
@mattrunyon mattrunyon deleted the monaco-autoclosing-strategy branch June 23, 2024 06:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants