-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Picker - formatter settings #1907
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1907 +/- ##
==========================================
+ Coverage 46.23% 46.26% +0.02%
==========================================
Files 645 646 +1
Lines 38241 38252 +11
Branches 9672 9673 +1
==========================================
+ Hits 17682 17697 +15
+ Misses 20506 20502 -4
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8bff576
to
c032c9b
Compare
@@ -38,7 +38,7 @@ export function useGetItemIndexByValue<TValue>({ | |||
return index === -1 ? null : index; | |||
} catch (err) { | |||
log.debug('Error seeking row', { column, value, columnValueType }); | |||
return null; | |||
throw err; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't bother logging it either - consumer either catches it and logs it or does something with it in which case the log would be extra spam. If it's uncaught would be logged as an uncaught promise anyway.
bindAllMethods
function. It now excludes gettersresolves #1889