-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PouchStorageTable using incorrect $ne operator #2011
fix: PouchStorageTable using incorrect $ne operator #2011
Conversation
Re-ran your failed e2e and it passed. I think it was just webkit timeouts, we are working to fix that. |
@bmingles Have added the test cases for the regex types, however,a fter adding them I kept getting this error: Figured that there was an issue with our old regex (but may have never been picked up given the any type), so I modified it. Let me know what you think about this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #1505
Changes:
PouchFilter
type to use $ne instead of $neq$regex
prop to be able to acceptRegExp
andstring
, rather than just string by defaultSteps Moving Forward:
Update: Apparently, there are some issues with PouchDB and jest tests, since it has not been updated to an ES6 module. (https://stackoverflow.com/questions/64905287/import-error-when-running-jest-tests-that-use-the-pouchdb-asyncstorage-adapter). Could create a
babel.config.js
, but not sure if we want to do that just for a function that is never used beyond an internal scope. Thus, going to omit unit tests for now.