fix: DH-17076 LayoutHints on TreeTables were not being applied #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
May 29, 2024
•
mofojed
commented
- Related to DH-17076
- Needed a Core patch: fix: Expose layoutHints in JS API for TreeTable deephaven-core#5555
- Tested using both the Groovy snippet from the ticket
- Fixes Column grouping layout hints are ignored on rollup tables #2035
- Related to DH-17076 - Needed a Core patch: deephaven/deephaven-core#5543 - Tested using both the Python and Groovy snippets from the ticket - Fixes deephaven#2035
mattrunyon
requested changes
May 29, 2024
mofojed
changed the title
|
@mattrunyon order shouldn't matter here, I added feature detection as well. |
mattrunyon
requested changes
May 29, 2024
Comment on lines
+65
to
+73
| test('layoutHints property does not exist should not crash', () => { | ||
| const columns = irisGridTestUtils.makeColumns(); | ||
| const table = irisGridTestUtils.makeTreeTable(columns, columns, 100, []); | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| delete (table as any).layoutHints; | ||
| const model = new IrisGridTreeTableModel(dh, table); | ||
|
|
||
| expect(model.layoutHints).toEqual(undefined); | ||
| }); |
There was a problem hiding this comment.
This test is identical to the test above it
There was a problem hiding this comment.
Not quite. undefined vs. property not existing, it is technically different. e.g.
var o = { foo: 'bar', fiz: undefined }
var o2 = { ...o }
delete o2.fiz
console.log(o.hasOwnProperty('fiz')) // true
console.log(o2.hasOwnProperty('fiz')) //false
mattrunyon
approved these changes
Jun 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.