Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: A few small cleanups for DateTimeInput #2062

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: A few small cleanups for DateTimeInput #2062

merged 2 commits into from
Jun 10, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jun 6, 2024

  • Don't allow an undefined to be returned
  • Export more types

@mofojed
fix: A few small cleanups for DateTimeInput
d1ac7fb 
- Don't allow an undefined to be returned
- Export more types
@mofojed mofojed requested a review from mattrunyon June 6, 2024 20:38
@mofojed @mattrunyon
Update packages/components/src/DateTimeInput.tsx
f0cdfd7 
Co-authored-by: Matthew Runyon <mattrunyonstuff@gmail.com>
@mofojed mofojed requested a review from mattrunyon June 7, 2024 15:38
@mofojed mofojed merged commit ec11736 into deephaven:main Jun 10, 2024
10 checks passed
@mofojed mofojed deleted the datetimeinput-cleanup branch June 10, 2024 18:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattrunyon mattrunyon mattrunyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofojed @mattrunyon