-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ComboBox - @deephaven/jsapi-components #2077
Conversation
fa5b8ea
to
0a0d7bc
Compare
f2b00e1
to
3465f98
Compare
3465f98
to
c0407f6
Compare
// Copy table so we can apply filters without affecting the original table. | ||
// (Note that this call is not actually applying any filters. Filter will be | ||
// applied in `useSearchableViewportData`.) | ||
const { data: tableCopy } = usePromiseFactory( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mofojed for reference, I think this is where we could apply addition filters as part of @AkshatJawne partition table work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it might make sense to just add it to this PR, but I'm fine either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing that needs updating is the PR description
Show passing in a ui.item_table_data_source
instead of passing in props for key_column
directly on combo_box
.
Jsapi support for ComboBox. Includes some splitting out of existing Picker logic to make code re-usable.
Should be testable with plugins PR deephaven/deephaven-plugins#588
I have also deployed an alpha 0.83.1-alpha-combobox.8 if you need it, although should only matter for types I think.
There is a known issue with inconsistent open as you type for table data sources.
#2115
resolves #2074