fix: make textValue default to key for Normalized Item #2113
Conversation
| @@ -105,7 +105,7 @@ describe.each([ | |||
| it.each([ | |||
| [ | |||
| { key: 'mock.key', textValue: undefined }, | |||
| 'Empty', | |||
| 'mock.key', | |||
There was a problem hiding this comment.
Minor test coverage regression:
Before:
Afer (lines 55,104 missing coverage):
There was a problem hiding this comment.
Do we have a test case for { key: '', textValue: undefined } resulting in Empty ?
There was a problem hiding this comment.
I have one for key being undefined and textvalue being undefined resulting in Empty, but not for key as an empty string, can add that as well if you would like: currently coverage is 100% though.
|
Ready for re-review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
+ Coverage 46.60% 46.64% +0.04%
==========================================
Files 679 679
Lines 38598 38634 +36
Branches 9779 9794 +15
==========================================
+ Hits 17988 18022 +34
- Misses 20558 20560 +2
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Resolves #2112