Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update IrisGridContextMenuHandler getHeaderActions return type to be more permissive #2117

Merged

Conversation

mattrunyon
Copy link
Collaborator

Needed for proper TS in deephaven/deephaven-plugins#522. Otherwise the class complains it can't properly extend IrisGridContextMenuHandler.

@mattrunyon mattrunyon requested a review from mofojed June 27, 2024 22:38
@mattrunyon mattrunyon self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.64%. Comparing base (e75e716) to head (ffe68fd).
Report is 1 commits behind head on main.

Files Patch % Lines
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2117   +/-   ##
=======================================
  Coverage   46.64%   46.64%           
=======================================
  Files         679      679           
  Lines       38632    38632           
  Branches     9792     9792           
=======================================
  Hits        18020    18020           
  Misses      20560    20560           
  Partials       52       52           
Flag Coverage Δ
unit 46.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 4e08b79 into deephaven:main Jun 28, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
@mattrunyon mattrunyon deleted the iris-grid-context-handler-return-type branch August 27, 2024 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants