Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow ComboBox to accept the FocusableRef for ref #2121

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jul 3, 2024

  • Wasn't allowing a ref to be passed in to ComboBox

- Wasn't allowing a ref to be passed in to ComboBox
@mofojed mofojed requested a review from bmingles July 3, 2024 15:42
@mofojed mofojed self-assigned this Jul 3, 2024
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah. Good catch.

Guessing we probably need this for Picker as well.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.58%. Comparing base (115e057) to head (4dc0cfc).

Files Patch % Lines
...ages/components/src/spectrum/comboBox/ComboBox.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   46.59%   46.58%   -0.01%     
==========================================
  Files         681      681              
  Lines       38430    38431       +1     
  Branches     9576     9786     +210     
==========================================
  Hits        17905    17905              
+ Misses      20515    20474      -41     
- Partials       10       52      +42     
Flag Coverage Δ
unit 46.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 8fe9bad into deephaven:main Jul 3, 2024
11 checks passed
@mofojed mofojed deleted the fix-combobox-props branch July 3, 2024 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants