Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: IrisGridTheme iconSize #2123

Merged
merged 10 commits into from
Jul 16, 2024
Merged

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Jul 3, 2024

This is part of the work needed for #885 that I felt would be better as a separate PR.

Snapshot changes are going to be slightly shifted sort icon and vertical center + slight left shift on tree table arrows.

@mattrunyon mattrunyon requested review from dsmmcken and mofojed July 3, 2024 22:35
@mattrunyon mattrunyon self-assigned this Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (50f2a6d) to head (7c7840f).

Files Patch % Lines
packages/iris-grid/src/IrisGridRenderer.ts 16.66% 10 Missing ⚠️
...ackages/iris-grid/src/IrisGridCellRendererUtils.ts 0.00% 7 Missing ⚠️
packages/grid/src/GridRenderer.ts 0.00% 4 Missing ⚠️
packages/iris-grid/src/IrisGridIcons.ts 0.00% 3 Missing ⚠️
packages/iris-grid/src/IrisGridTextCellRenderer.ts 0.00% 2 Missing ⚠️
.../mousehandlers/IrisGridCellOverflowMouseHandler.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
- Coverage   46.62%   46.62%   -0.01%     
==========================================
  Files         685      685              
  Lines       38492    38493       +1     
  Branches     9590     9589       -1     
==========================================
  Hits        17948    17948              
- Misses      20534    20535       +1     
  Partials       10       10              
Flag Coverage Δ
unit 46.62% <10.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/grid/src/GridRenderer.ts Outdated Show resolved Hide resolved
packages/grid/src/GridRenderer.ts Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridCellRendererUtils.ts Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridIcons.ts Show resolved Hide resolved
mofojed
mofojed previously approved these changes Jul 15, 2024
@mattrunyon mattrunyon merged commit 58ee88d into deephaven:main Jul 16, 2024
11 checks passed
@mattrunyon mattrunyon deleted the iris-grid-icon-size branch July 16, 2024 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants