Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the session wrapper from the embedded widget app #2158

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jul 18, 2024

  • We creating a new session and getting the session details, even though that was unnecessary for fetching the object itself since we already have a connection
  • Just pass isConsoleAvailable: false here, since we will never have the console available in the embedded widget scenario
  • Should speed up the embed-widget fetch quite a bit

- We creating a new session and getting the session details, even though that was unnecessary for fetching the object itself since we already have a connection
- Just pass `isConsoleAvailable: false` here, since we will never have the console available in the embedded widget scenario
@mofojed mofojed requested a review from mattrunyon July 18, 2024 18:31
@mofojed mofojed self-assigned this Jul 18, 2024
@mattrunyon
Copy link
Collaborator

Shouldn't need a V+ backport. This was added in 0.83.0 b090f20

@mofojed mofojed enabled auto-merge (squash) July 18, 2024 18:35
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.68%. Comparing base (6362eb7) to head (06d1afa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2158   +/-   ##
=======================================
  Coverage   46.68%   46.68%           
=======================================
  Files         691      691           
  Lines       38588    38588           
  Branches     9622     9622           
=======================================
  Hits        18016    18016           
  Misses      20561    20561           
  Partials       11       11           
Flag Coverage Δ
unit 46.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit b76c1d7 into deephaven:main Jul 18, 2024
11 checks passed
@mofojed mofojed deleted the embed-widget-session-wrapper branch July 18, 2024 18:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants