feat: Export Internationalized Date Types for DatePicker #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2170 +/- ##
=======================================
Coverage 46.67% 46.67%
=======================================
Files 692 692
Lines 38628 38628
Branches 9631 9631
=======================================
Hits 18028 18028
Misses 20589 20589
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
reviewed
Jul 24, 2024
|
|
||
| export type DateValue = CalendarDate | CalendarDateTime | ZonedDateTime; | ||
|
|
||
| export type MappedDateValue<T> = T extends ZonedDateTime |
There was a problem hiding this comment.
I would probably add a comment on these types describing why we need them.
There was a problem hiding this comment.
Pushed an update with some comments.
bmingles
requested changes
Jul 24, 2024
|
I have read the CLA Document and I hereby sign the CLA |
deephaven-internal
added a commit
to deephaven/cla
that referenced
this pull request
Jul 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.