Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow ref callback for Chart and ChartPanel #2174

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

mattrunyon
Copy link
Collaborator

Needed for deephaven/deephaven-plugins#657 because when using ChartPanel containerRef is undefined on first render due to the loading logic. This means we need to allow a ref callback so we can use a callback to set state in the plugin and add event listeners to the container when it actually exists

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.67%. Comparing base (a5cb947) to head (8b3ca50).
Report is 4 commits behind head on main.

Files Patch % Lines
packages/chart/src/Chart.tsx 0.00% 2 Missing ⚠️
...ages/components/src/spectrum/comboBox/ComboBox.tsx 0.00% 1 Missing ⚠️
packages/components/src/spectrum/picker/Picker.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2174   +/-   ##
=======================================
  Coverage   46.67%   46.67%           
=======================================
  Files         692      692           
  Lines       38628    38624    -4     
  Branches     9631     9625    -6     
=======================================
  Hits        18028    18028           
+ Misses      20589    20585    -4     
  Partials       11       11           
Flag Coverage Δ
unit 46.67% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/utils/src/mergeRefs.ts Outdated Show resolved Hide resolved
@mattrunyon mattrunyon requested a review from mofojed July 30, 2024 17:05
@mattrunyon mattrunyon merged commit 56d1fa9 into deephaven:main Jul 30, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
@mattrunyon mattrunyon deleted the chart-ref-fix branch July 30, 2024 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants