feat: Set selected theme via query string param #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
+ Coverage 46.73% 46.74% +0.01%
==========================================
Files 693 693
Lines 38594 38602 +8
Branches 9652 9838 +186
==========================================
+ Hits 18038 18046 +8
Misses 20545 20545
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
reviewed
Aug 28, 2024
| @@ -43,6 +43,7 @@ export type ThemeIconsRequiringManualColorChanges = | |||
|
|
|||
| export const DEFAULT_DARK_THEME_KEY = 'default-dark' satisfies BaseThemeKey; | |||
| export const DEFAULT_LIGHT_THEME_KEY = 'default-light' satisfies BaseThemeKey; | |||
| export const THEME_KEY_OVERRIDE_QUERY_PARAM = 'themeKey'; | |||
There was a problem hiding this comment.
Should we bother with the Key part of this param? May as well just call it theme.
There was a problem hiding this comment.
Didn't see a response to this - why not just call it theme?
There was a problem hiding this comment.
ah, didn't see this comment. I have renamed it.
Comment on lines
54
to
57
| () => | ||
| themeKeyOverride ?? | ||
| getThemePreloadData()?.themeKey ?? | ||
| DEFAULT_DARK_THEME_KEY |
There was a problem hiding this comment.
May as well wrap this all in a function, getDefaultTheme or getDefaultSelectedTheme. Then this just becomes.
... useState<string>(getDefaultSelectedTheme)
mofojed
approved these changes
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting selected theme via a
themeKeyquery string param.Can test by passing
themeKey=default-lightandthemeKey=default-darkas query string params.resolves #2203