fix: DH-17730: Fix Proxy Model Undefined Formatter (#2237) #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://deephaven.atlassian.net/browse/DH-17730 in Enterprise. Will need to be cherry picked back to v0.85. web-client-ui issue is deephaven#2234
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.85 #2238 +/- ##
==============================================
Coverage 46.65% 46.65%
==============================================
Files 685 685
Lines 38491 38495 +4
Branches 9590 9590
==============================================
+ Hits 17958 17961 +3
- Misses 20523 20524 +1
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vbabich
approved these changes
Sep 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2234
Fixes https://deephaven.atlassian.net/browse/DH-17730 in Enterprise. This is the cherry pick back to v0.85.