Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reuse dashboard tabs when reassigning the variable #2243

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

mattrunyon
Copy link
Collaborator

Fixes #1971

Tested with this code run 1 line at a time

import deephaven.ui as ui

a = ui.dashboard(ui.text("Hello"))

a = ui.dashboard(ui.text("World"))

a = ui.text("Hello")

a = ui.dashboard(ui.text("Hello"))

del a

Also tested dashboards still load in embed-widget. There was a race condition since the makeUseListenerFunction hook was using useEffect. This caused the event to emit between the event hub being set and the listener being added.

@mattrunyon mattrunyon requested a review from a team October 2, 2024 20:52
@mattrunyon mattrunyon self-assigned this Oct 2, 2024
@mattrunyon mattrunyon requested review from ethanalvizo, a team and dgodinez-dh and removed request for a team and ethanalvizo October 2, 2024 20:52
@mattrunyon mattrunyon merged commit d2c6eab into deephaven:main Oct 2, 2024
10 checks passed
@mattrunyon mattrunyon deleted the dashboard-tab-replacement branch October 2, 2024 23:22
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.44%. Comparing base (aad0aa6) to head (7f47596).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2243      +/-   ##
==========================================
+ Coverage   46.42%   46.44%   +0.01%     
==========================================
  Files         698      698              
  Lines       38750    38736      -14     
  Branches     9885     9885              
==========================================
- Hits        17990    17989       -1     
+ Misses      20706    20693      -13     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace dashboard tabs when the variable is reassigned or deleted
2 participants