fix: Change ruff errors to warnings and fix config saving #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
reviewed
Oct 4, 2024
| linter: { | ||
| ...ruffSettings, | ||
| config: | ||
| JSON.stringify(newValue) === |
There was a problem hiding this comment.
Is the argument mismatch in the JSON.stringify calls intentional?
There was a problem hiding this comment.
Yes. I want to check if the value was reset to default here, but the objects won't be the same. The other option was to do this check in the settings modal before onSave is called and then call with null or undefined to indicate the default.
There was a problem hiding this comment.
Oh, I misread this. I thought your were passing in undefined, 2 to one of the JSON.stringify calls
bmingles
reviewed
Oct 4, 2024
| }) | ||
| ); | ||
| MonacoProviders.setRuffSettings(newValue); | ||
| }, | ||
| [dispatch, ruffSettings] | ||
| ); | ||
|
|
||
| const [val, setVal] = useState(JSON.stringify(ruffConfig, null, 2)); | ||
| const val = JSON.stringify(ruffConfig, null, 2); |
There was a problem hiding this comment.
I don't think it matters. The object isn't that big and there's still some overhead to do the string comparison for memoization. Also the component shouldn't re-render often.
bmingles
requested changes
Oct 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all except syntax errors to warning underlines instead of error underline since they are not actual errors.
Also changed redux to not save if the config matches the default. This should fix an edge case where a user opens the settings editor just to see what the config is, then hits "Save". Previously, this would save the current defaults as their settings and then if the defaults changed they would not get updated settings. This way, if a user was on defaults and the default changes they will get the new default.
Also added a little bit of debug logging for Ruff.