Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add monaco docs CSS override #2250

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

stevenwu15
Copy link
Contributor

@stevenwu15 stevenwu15 commented Oct 7, 2024

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.59%. Comparing base (9e83393) to head (4304b29).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
+ Coverage   46.41%   46.59%   +0.17%     
==========================================
  Files         698      698              
  Lines       38767    38768       +1     
  Branches     9683     9683              
==========================================
+ Hits        17993    18063      +70     
+ Misses      20763    20694      -69     
  Partials       11       11              
Flag Coverage Δ
unit 46.59% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenwu15 stevenwu15 self-assigned this Oct 7, 2024
@stevenwu15
Copy link
Contributor Author

  • min-width - it should have a min width to avoid looking thin
  • hr - make horizontal breaks visible
  • blockquote - make block quotes have a margin to make them indented

@stevenwu15 stevenwu15 marked this pull request as ready for review October 7, 2024 15:07
packages/console/src/ConsoleInput.scss Outdated Show resolved Hide resolved
packages/console/src/ConsoleInput.scss Outdated Show resolved Hide resolved
packages/console/src/ConsoleInput.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, one last thing. Comment what this is for. In future I could see a case of someone searching this codebase and not finding any matches for it so it could accidentally get deleted without knowing it originates elsewhere.

@stevenwu15 stevenwu15 merged commit 6b949d5 into deephaven:main Oct 17, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@stevenwu15 stevenwu15 linked an issue Oct 18, 2024 that may be closed by this pull request
@stevenwu15 stevenwu15 deleted the 2247-formatted-markdown branch October 21, 2024 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown formatted autocomplete
2 participants