Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove RefreshBootstrap and refresh token handling #2257

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Oct 16, 2024

  • This never worked and doesn't get used anyway, since we attempt re-login with the pre-shared key if provided
  • Tested by logging into a server with a pre-shared key, then hitting Refresh and ensuring it logged in again without being prompted

- This never worked and actually doesn't get used anyway, since we attempt re-login with the pre-shared key if provided
@mofojed mofojed requested review from a team and dgodinez-dh and removed request for a team October 16, 2024 14:38
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.61%. Comparing base (229adf0) to head (4560be7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
+ Coverage   46.57%   46.61%   +0.04%     
==========================================
  Files         698      696       -2     
  Lines       38767    38731      -36     
  Branches     9866     9802      -64     
==========================================
  Hits        18054    18054              
+ Misses      20702    20623      -79     
- Partials       11       54      +43     
Flag Coverage Δ
unit 46.61% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed requested review from a team and dgodinez-dh and removed request for dgodinez-dh and a team October 16, 2024 19:36
@mofojed mofojed merged commit 5686032 into deephaven:main Oct 23, 2024
11 checks passed
@mofojed mofojed deleted the remove-refresh-token branch October 23, 2024 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants