Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add thousands format for numbers #2261

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

stevenwu15
Copy link
Contributor

@stevenwu15 stevenwu15 self-assigned this Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.59%. Comparing base (6b949d5) to head (3b390d4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2261   +/-   ##
=======================================
  Coverage   46.59%   46.59%           
=======================================
  Files         698      698           
  Lines       38768    38770    +2     
  Branches     9891     9866   -25     
=======================================
+ Hits        18063    18065    +2     
  Misses      20651    20651           
  Partials       54       54           
Flag Coverage Δ
unit 46.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenwu15 stevenwu15 marked this pull request as ready for review October 21, 2024 20:48
@stevenwu15 stevenwu15 requested review from a team and dgodinez-dh and removed request for a team October 21, 2024 20:54
@stevenwu15 stevenwu15 merged commit 0802f8a into deephaven:main Oct 22, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for "Thousands" in default number format dropdown
2 participants