Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsapi-nodejs downloader should raise error on 404 status #2271

Closed
bmingles opened this issue Oct 29, 2024 · 0 comments · Fixed by #2272
Closed

jsapi-nodejs downloader should raise error on 404 status #2271

bmingles opened this issue Oct 29, 2024 · 0 comments · Fixed by #2272
Assignees
Labels
enhancement New feature or request triage Issue requires triage

Comments

@bmingles
Copy link
Contributor

The jsapi-nodejs downloader currently saves html text for a 404 page if an incorrect jsapi url is provided. This surfaces later when attempting to import the module with an error message about invalid < character which is not very helpful in diagnosing the problem. We should add an explicit 404 check.

@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Oct 29, 2024
@bmingles bmingles self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Issue requires triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant