Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@deephaven/jsapi-nodejs - Externalize esbuild dependency #2284

Closed
bmingles opened this issue Nov 7, 2024 · 0 comments · Fixed by #2285
Closed

@deephaven/jsapi-nodejs - Externalize esbuild dependency #2284

bmingles opened this issue Nov 7, 2024 · 0 comments · Fixed by #2285
Assignees
@bmingles
Labels
enhancement New feature or request triage Issue requires triage

Comments

@bmingles
Copy link
Contributor

bmingles commented Nov 7, 2024

The esbuild dependency needs to be externalized as bundling it can cause errors in consumers. I'm currently getting the following error when trying to use in the vscode extension.

Error: The esbuild JavaScript API cannot be bundled. Please mark the "esbuild" package as external so it's not included in the bundle.
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Nov 7, 2024
@bmingles bmingles self-assigned this Nov 7, 2024
@bmingles bmingles mentioned this issue Nov 7, 2024
Merged
@vbabich vbabich closed this as completed in 8ccab6d Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Externalized esbuild dependency (2284) bmingles/web-client-ui
1 participant
@bmingles