Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS version listed by the IDE is incorrect #2289

Closed
chipkent opened this issue Nov 8, 2024 · 4 comments · Fixed by #2291
Closed

OS version listed by the IDE is incorrect #2289

chipkent opened this issue Nov 8, 2024 · 4 comments · Fixed by #2291
Assignees
Labels
bug Something isn't working
Milestone

Comments

@chipkent
Copy link
Member

chipkent commented Nov 8, 2024

My mac is 14.2.1. In the IDE, the version is reported as 10.15.7. The problem exists in both normal and incognito modes. It also exists on Chrome and Safari.

@chipkent chipkent added bug Something isn't working triage Issue requires triage labels Nov 8, 2024
@mofojed mofojed transferred this issue from deephaven/deephaven-plugins Nov 11, 2024
@mofojed
Copy link
Member

mofojed commented Nov 11, 2024

Reproducible on my Mac which is on 15.1. Seems to a known issue across browsers: https://bugs.webkit.org/show_bug.cgi?id=216593

@mattrunyon
Copy link
Collaborator

@mofojed What is your user agent string? We just parse that using a library, so would be good to check if it's an issue with the UA or with the parser we use (bowser which hasn't been updated in 4 years)

@mattrunyon
Copy link
Collaborator

We should probably just drop OS version. It's not accurate and there are more pushes towards removing or setting a fixed version. See this page for an example w/ Android/chrome fixing some versions.

userAgentData might be the best replacement, but it's currently a chromium only implementation

@dsmmcken
Copy link
Contributor

Renaming "OS Name" to "User Agent OS", as that is still the true value reported by the browser. Don't want to drop it as more info is better than less.

Bowser is probably one of those packages that is "complete", it is splitting out the UA correctly. That's just what the os is reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants