Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI should allow using doubles as rollup key columns #2295

Closed
rbasralian opened this issue Nov 14, 2024 · 1 comment · Fixed by #2311
Closed

Web UI should allow using doubles as rollup key columns #2295

rbasralian opened this issue Nov 14, 2024 · 1 comment · Fixed by #2311
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rbasralian
Copy link

A user found that they can't use double columns as key columns in rollups they create in the web UI. Although there are many cases where doubles don't make sense as key columns (e.g. truly continuous values such as prices or calculation outputs), there are also plenty of cases where there is a distinct set of values that does make sense as key columns (e.g. 1.0, 2.0, 3.0, etc.)

@rbasralian rbasralian added the enhancement New feature or request label Nov 14, 2024
@mofojed
Copy link
Member

mofojed commented Nov 19, 2024

We filter out decimal types by default:

static isGroupable(column: dh.Column): boolean {

We could just not do that and it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants