Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLM plotting does not filter by time bounds #50

Open
wx4stg opened this issue Aug 26, 2024 · 1 comment
Open

GLM plotting does not filter by time bounds #50

wx4stg opened this issue Aug 26, 2024 · 1 comment

Comments

@wx4stg
Copy link
Contributor

wx4stg commented Aug 26, 2024

I'm not really sure what the default behaviour "should" be here, but when plotting GLM events on an already existing xlma BlankPlot, the GLM events are plotted on the plan and cross sectional axes regardless of whether or not the events fall in the timeframe specified by the BlankPlot's tlim

@deeplycloudy
Copy link
Owner

I believe the way I handled this in the draft implementation was to have a filtering function that was called as part of a custom subclass in the notebook. So those subsetting functions exist and can get rolled into an if has_glm: part of the default interactive class. Maybe blank_plot can call the same subsetting logic for the static plot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants