feedback

Author: Artmann

packages/server/src/complete/complete.ts

@@ -355,7 +355,9 @@ class Completer {
     // This handles the case where "SELECT * FROM a" parses successfully
     // but we still want to suggest tables starting with "a"
     const parsedFromClause = getFromNodesFromClause(this.sql)
-    const fromNodes = parsedFromClause?.from?.tables || []
+    const fromNodes = getAllNestedFromNodes(
+      parsedFromClause?.from?.tables || []
+    )
     const subqueryTables = createTablesFromFromNodes(fromNodes)
     const schemaAndSubqueries = this.schema.tables.concat(subqueryTables)
 

packages/server/test/complete/complete_table.test.ts

@@ -185,7 +185,8 @@ describe('TableName completion', () => {
   })
 
   test('complete table name when SQL parses successfully', () => {
-    // This tests Issue 1 - when the parser treats partial table name as valid
+    // This tests the case when the parser treats partial table name as valid
+    // See https://github.com/deepnote/sql-language-server/issues/24
     const schema = {
       tables: [
         { catalog: null, database: null, tableName: 'actor', columns: [] },