Skip to content

Commit 058895c

Browse files
committed
types
1 parent 614985a commit 058895c

File tree

3 files changed

+6
-20
lines changed

3 files changed

+6
-20
lines changed

src/interactive-window/shiftEnterBanner.unit.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ import {
1010
isTestExecution,
1111
isUnitTestExecution,
1212
setTestExecution,
13-
setUnitTestExecution,
14-
Telemetry
13+
setUnitTestExecution
1514
} from '../platform/common/constants';
1615
import {
1716
IConfigurationService,

src/platform/common/experiments/telemetry.unit.test.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,14 @@ import * as Telemetry from '../../../platform/telemetry/index';
99
suite('Experimentation telemetry', () => {
1010
const event = 'SomeEventName';
1111

12-
let telemetryEvents: { eventName: string; properties: object }[] = [];
13-
let sendTelemetryEventStub: sinon.SinonStub;
1412
let setSharedPropertyStub: sinon.SinonStub;
1513
let experimentTelemetry: ExperimentationTelemetry;
1614
let eventProperties: Map<string, string>;
1715

1816
setup(() => {
19-
sendTelemetryEventStub = sinon
20-
.stub(Telemetry, 'sendTelemetryEvent')
21-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
22-
.callsFake((eventName: string, _, properties: any) => {
23-
const telemetry = { eventName, properties };
24-
telemetryEvents.push(telemetry);
25-
});
17+
sinon.stub(Telemetry, 'sendTelemetryEvent').callsFake(() => {
18+
// Stub for telemetry (now disabled)
19+
});
2620
setSharedPropertyStub = sinon.stub(Telemetry, 'setSharedProperty');
2721

2822
eventProperties = new Map<string, string>();
@@ -33,7 +27,6 @@ suite('Experimentation telemetry', () => {
3327
});
3428

3529
teardown(() => {
36-
telemetryEvents = [];
3730
sinon.restore();
3831
});
3932

src/platform/telemetry/index.unit.test.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,11 @@ import * as sinon from 'sinon';
66
import { expect } from 'chai';
77
import { Disposable } from 'vscode';
88
import { EXTENSION_ROOT_DIR } from '../constants.node';
9-
import {
10-
_resetSharedProperties,
11-
getTelemetryReporter,
12-
isTelemetryDisabled,
13-
sendTelemetryEvent,
14-
setSharedProperty
15-
} from '../../telemetry';
9+
import { _resetSharedProperties, getTelemetryReporter, sendTelemetryEvent, setSharedProperty } from '../../telemetry';
1610
import { isUnitTestExecution, isTestExecution, setTestExecution, setUnitTestExecution } from '../common/constants';
1711
import { sleep } from '../../test/core';
1812
import { waitForCondition } from '../../test/common';
19-
import { mockedVSCodeNamespaces, resetVSCodeMocks } from '../../test/vscode-mock';
13+
import { resetVSCodeMocks } from '../../test/vscode-mock';
2014
import { IDisposable } from '../common/types';
2115
import { dispose } from '../common/utils/lifecycle';
2216

0 commit comments

Comments
 (0)