Address PR feedback: use Uri.joinPath, assert exact cell count, extract dynamic import helper

Co-Authored-By: Filip Pyrek <PyrekFilip@gmail.com>

Author: devin-ai-integration[bot]

src/notebooks/deepnote/deepnoteExplorerView.ts

@@ -356,7 +356,7 @@ export class DeepnoteExplorerView {
                 const outputFileName = `${projectName}.deepnote`;
                 const outputPath = Uri.joinPath(workspaceFolder.uri, outputFileName).path;
 
-                const { convertIpynbFilesToDeepnoteFile } = await import('@deepnote/convert');
+                const convertIpynbFilesToDeepnoteFile = await this.getConverter();
                 await convertIpynbFilesToDeepnoteFile(inputFilePaths, {
                     outputPath: outputPath,
                     projectName: projectName
@@ -379,6 +379,11 @@ export class DeepnoteExplorerView {
         }
     }
 
+    private async getConverter() {
+        const { convertIpynbFilesToDeepnoteFile } = await import('@deepnote/convert');
+        return convertIpynbFilesToDeepnoteFile;
+    }
+
     private async importJupyterNotebook(): Promise<void> {
         if (!workspace.workspaceFolders || workspace.workspaceFolders.length === 0) {
             const selection = await window.showInformationMessage(
@@ -429,7 +434,7 @@ export class DeepnoteExplorerView {
                 // File doesn't exist, continue
             }
 
-            const { convertIpynbFilesToDeepnoteFile } = await import('@deepnote/convert');
+            const convertIpynbFilesToDeepnoteFile = await this.getConverter();
             await convertIpynbFilesToDeepnoteFile(inputFilePaths, {
                 outputPath: outputUri.path,
                 projectName: projectName

src/test/datascience/notebook/deepnote.vscode.test.ts

@@ -1,6 +1,5 @@
 /* eslint-disable @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires */
 import { assert } from 'chai';
-import * as path from '../../../platform/vscode-path/path';
 import { Uri, workspace } from 'vscode';
 import { IDisposable } from '../../../platform/common/types';
 import { captureScreenShot, IExtensionTestApi } from '../../common.node';
@@ -13,8 +12,13 @@ import { IDeepnoteNotebookManager } from '../../../notebooks/types';
 suite('Deepnote Integration Tests @kernelCore', function () {
     let api: IExtensionTestApi;
     const disposables: IDisposable[] = [];
-    const deepnoteFilePath = Uri.file(
-        path.join(EXTENSION_ROOT_DIR_FOR_TESTS, 'src', 'test', 'datascience', 'notebook', 'test.deepnote')
+    const deepnoteFilePath = Uri.joinPath(
+        Uri.file(EXTENSION_ROOT_DIR_FOR_TESTS),
+        'src',
+        'test',
+        'datascience',
+        'notebook',
+        'test.deepnote'
     );
     this.timeout(240_000);
 
@@ -57,7 +61,7 @@ suite('Deepnote Integration Tests @kernelCore', function () {
         logger.debug(`Opened notebook with type: ${nbDocument.notebookType}, cells: ${nbDocument.cellCount}`);
 
         assert.equal(nbDocument.notebookType, 'deepnote', 'Notebook type should be deepnote');
-        assert.isTrue(nbDocument.cellCount > 0, 'Notebook should have cells');
+        assert.equal(nbDocument.cellCount, 3, 'Notebook should have 3 cells');
 
         assert.equal(nbDocument.metadata?.deepnoteProjectId, 'test-project-id', 'Project ID should match');
         assert.equal(nbDocument.metadata?.deepnoteNotebookId, 'main-notebook-id', 'Notebook ID should match');