Skip to content

Commit c04a3ff

Browse files
committed
fix: Fix SQL dataframe integration
Signed-off-by: Tomas Kislan <tomas@kislan.sk>
1 parent 065b4c0 commit c04a3ff

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

src/platform/notebooks/deepnote/sqlIntegrationEnvironmentVariablesProvider.ts

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,19 @@ export class SqlIntegrationEnvironmentVariablesProvider implements ISqlIntegrati
199199
return envVars;
200200
}
201201

202+
// Always add the internal DuckDB integration
203+
const dataframeSqlIntegrationEnvVarName = convertToEnvironmentVariableName(
204+
getSqlEnvVarName(DATAFRAME_SQL_INTEGRATION_ID)
205+
);
206+
const dataframeSqlIntegrationCredentialsJson = JSON.stringify({
207+
url: 'deepnote+duckdb:///:memory:',
208+
params: {},
209+
param_style: 'qmark'
210+
});
211+
212+
envVars[dataframeSqlIntegrationEnvVarName] = dataframeSqlIntegrationCredentialsJson;
213+
logger.debug(`SqlIntegrationEnvironmentVariablesProvider: Added env var for dataframe SQL integration`);
214+
202215
// Scan all cells for SQL integration IDs
203216
const integrationIds = this.scanNotebookForIntegrations(notebook);
204217
if (integrationIds.size === 0) {
@@ -219,17 +232,7 @@ export class SqlIntegrationEnvironmentVariablesProvider implements ISqlIntegrati
219232
try {
220233
// Handle internal DuckDB integration specially
221234
if (integrationId === DATAFRAME_SQL_INTEGRATION_ID) {
222-
const envVarName = convertToEnvironmentVariableName(getSqlEnvVarName(integrationId));
223-
const credentialsJson = JSON.stringify({
224-
url: 'deepnote+duckdb:///:memory:',
225-
params: {},
226-
param_style: 'qmark'
227-
});
228-
229-
envVars[envVarName] = credentialsJson;
230-
logger.debug(
231-
`SqlIntegrationEnvironmentVariablesProvider: Added env var for dataframe SQL integration`
232-
);
235+
// Internal DuckDB integration is handled above
233236
continue;
234237
}
235238

0 commit comments

Comments
 (0)