fix: registered kernel is now recognized in ui

Author: saltenasl

DEEPNOTE_KERNEL_IMPLEMENTATION.md

@@ -104,7 +104,7 @@ Create DeepnoteKernelConnectionMetadata
         ↓
 Register controller with IControllerRegistration
         ↓
-Execute notebook.selectKernel command
+Set controller affinity to Preferred (auto-selects kernel)
         ↓
 User runs cell → Executes on Deepnote kernel
 ```

src/notebooks/controllers/controllerRegistration.ts

@@ -236,14 +236,14 @@ export class ControllerRegistration implements IControllerRegistration, IExtensi
     }
     addOrUpdate(
         metadata: KernelConnectionMetadata,
-        types: ('jupyter-notebook' | 'interactive')[]
+        types: ('jupyter-notebook' | 'interactive' | 'deepnote')[]
     ): IVSCodeNotebookController[] {
         const { added, existing } = this.addImpl(metadata, types, true);
         return added.concat(existing);
     }
     addImpl(
         metadata: KernelConnectionMetadata,
-        types: ('jupyter-notebook' | 'interactive')[],
+        types: ('jupyter-notebook' | 'interactive' | 'deepnote')[],
         triggerChangeEvent: boolean
     ): { added: IVSCodeNotebookController[]; existing: IVSCodeNotebookController[] } {
         const added: IVSCodeNotebookController[] = [];
@@ -350,16 +350,19 @@ export class ControllerRegistration implements IControllerRegistration, IExtensi
     }
     get(
         metadata: KernelConnectionMetadata,
-        notebookType: 'jupyter-notebook' | 'interactive'
+        notebookType: 'jupyter-notebook' | 'interactive' | 'deepnote'
     ): IVSCodeNotebookController | undefined {
         const id = this.getControllerId(metadata, notebookType);
         return this.registeredControllers.get(id);
     }
 
     private getControllerId(
         metadata: KernelConnectionMetadata,
-        viewType: typeof JupyterNotebookView | typeof InteractiveWindowView
+        viewType: typeof JupyterNotebookView | typeof InteractiveWindowView | 'deepnote'
     ) {
+        if (viewType === 'deepnote') {
+            return metadata.id;
+        }
         return viewType === JupyterNotebookView ? metadata.id : `${metadata.id}${InteractiveControllerIdSuffix}`;
     }
 

src/notebooks/controllers/types.ts

@@ -83,7 +83,7 @@ export interface IControllerRegistration {
      */
     addOrUpdate(
         metadata: KernelConnectionMetadata,
-        types: (typeof JupyterNotebookView | typeof InteractiveWindowView)[]
+        types: (typeof JupyterNotebookView | typeof InteractiveWindowView | 'deepnote')[]
     ): IVSCodeNotebookController[];
     /**
      * Gets the controller for a particular connection
@@ -92,7 +92,7 @@ export interface IControllerRegistration {
      */
     get(
         connection: KernelConnectionMetadata,
-        notebookType: typeof JupyterNotebookView | typeof InteractiveWindowView
+        notebookType: typeof JupyterNotebookView | typeof InteractiveWindowView | 'deepnote'
     ): IVSCodeNotebookController | undefined;
 }
 

src/notebooks/deepnote/deepnoteKernelAutoSelector.node.ts

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import { inject, injectable } from 'inversify';
-import { NotebookDocument, workspace, commands } from 'vscode';
+import { NotebookDocument, workspace, NotebookControllerAffinity } from 'vscode';
 import { IExtensionSyncActivationService } from '../../platform/activation/types';
 import { IDisposableRegistry } from '../../platform/common/types';
 import { logger } from '../../platform/logging';
@@ -15,7 +15,7 @@ import {
 } from '../../kernels/deepnote/types';
 import { DeepnoteKernelConnectionMetadata } from '../../kernels/deepnote/types';
 import { IControllerRegistration } from '../controllers/types';
-import { JupyterNotebookView, JVSC_EXTENSION_ID } from '../../platform/common/constants';
+import { JVSC_EXTENSION_ID } from '../../platform/common/constants';
 import { getDisplayPath } from '../../platform/common/platform/fs-paths';
 import { createInterpreterKernelSpec } from '../../kernels/helpers';
 import { JupyterServerProviderHandle } from '../../kernels/jupyter/types';
@@ -116,8 +116,8 @@ export class DeepnoteKernelAutoSelector implements IDeepnoteKernelAutoSelector,
                 serverProviderHandle
             });
 
-            // Register controller
-            const controllers = this.controllerRegistration.addOrUpdate(connectionMetadata, [JupyterNotebookView]);
+            // Register controller for deepnote notebook type
+            const controllers = this.controllerRegistration.addOrUpdate(connectionMetadata, [DEEPNOTE_NOTEBOOK_TYPE]);
 
             if (controllers.length === 0) {
                 logger.error('Failed to create Deepnote kernel controller');
@@ -127,11 +127,9 @@ export class DeepnoteKernelAutoSelector implements IDeepnoteKernelAutoSelector,
             const controller = controllers[0];
             logger.info(`Created Deepnote kernel controller: ${controller.id}`);
 
-            // Auto-select the controller for this notebook
-            await commands.executeCommand('notebook.selectKernel', {
-                id: controller.id,
-                extension: JVSC_EXTENSION_ID
-            });
+            // Auto-select the controller for this notebook using affinity
+            // Setting NotebookControllerAffinity.Preferred will make VSCode automatically select this controller
+            controller.controller.updateNotebookAffinity(notebook, NotebookControllerAffinity.Preferred);
 
             logger.info(`Successfully auto-selected Deepnote kernel for ${getDisplayPath(notebook.uri)}`);
         } catch (ex) {