feedback

Author: Artmann

src/notebooks/deepnote/deepnoteDataConverter.ts

@@ -243,9 +243,9 @@ export class DeepnoteDataConverter {
                 } else if (item.mime === 'application/json') {
                     data['application/json'] = JSON.parse(new TextDecoder().decode(item.data));
                 } else if (item.mime === 'image/png') {
-                    data['image/png'] = this.uint8ArrayToBase64(new Uint8Array(item.data));
+                    data['image/png'] = this.uint8ArrayToBase64(item.data);
                 } else if (item.mime === 'image/jpeg') {
-                    data['image/jpeg'] = this.uint8ArrayToBase64(new Uint8Array(item.data));
+                    data['image/jpeg'] = this.uint8ArrayToBase64(item.data);
                 } else if (item.mime === 'application/vnd.deepnote.dataframe.v3+json') {
                     data['application/vnd.deepnote.dataframe.v3+json'] = JSON.parse(
                         new TextDecoder().decode(item.data)

src/notebooks/deepnote/deepnoteSerializer.ts

@@ -11,30 +11,35 @@ export { DeepnoteBlock, DeepnoteNotebook, DeepnoteOutput, DeepnoteFile } from '.
 
 /**
  * Deep clones an object while removing circular references.
- * Circular references are replaced with undefined to make the object serializable.
+ * Uses a recursion stack pattern to only drop true cycles, preserving shared references.
  */
-function cloneWithoutCircularRefs<T>(obj: T, seen = new WeakSet()): T {
+function cloneWithoutCircularRefs<T>(obj: T, seen = new WeakSet<object>()): T {
     if (obj === null || typeof obj !== 'object') {
         return obj;
     }
 
-    if (seen.has(obj)) {
+    if (seen.has(obj as object)) {
+        // True circular reference on the current path - drop it
         return undefined as T;
     }
 
-    seen.add(obj);
+    seen.add(obj as object);
 
-    if (Array.isArray(obj)) {
-        return obj.map((item) => cloneWithoutCircularRefs(item, seen)) as T;
-    }
+    try {
+        if (Array.isArray(obj)) {
+            return obj.map((item) => cloneWithoutCircularRefs(item, seen)) as T;
+        }
 
-    const clone: Record<string, unknown> = {};
+        const clone: Record<string, unknown> = {};
 
-    for (const key of Object.keys(obj)) {
-        clone[key] = cloneWithoutCircularRefs((obj as Record<string, unknown>)[key], seen);
-    }
+        for (const key of Object.keys(obj as Record<string, unknown>)) {
+            clone[key] = cloneWithoutCircularRefs((obj as Record<string, unknown>)[key], seen);
+        }
 
-    return clone as T;
+        return clone as T;
+    } finally {
+        seen.delete(obj as object);
+    }
 }
 
 /**