Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (fix/origin_text_for_bot_utters): add updating origin text #101

Merged
merged 3 commits into from
Jul 30, 2020
Merged

fix (fix/origin_text_for_bot_utters): add updating origin text #101

merged 3 commits into from
Jul 30, 2020

Conversation

kudep
Copy link
Contributor

@kudep kudep commented Jul 22, 2020

PR for #100 issue

@kudep kudep self-assigned this Jul 22, 2020
@kudep kudep added the enhancement New feature or request label Jul 22, 2020
@kudep kudep linked an issue Jul 22, 2020 that may be closed by this pull request
field orig_text is empty #100
Open
@kudep kudep requested a review from IgnatovFedor July 22, 2020 07:44
@yurakuratov
Copy link

add_bot_utterance_last_chance and add_failure_bot_utterance should be also updated

@kudep
Copy link
Contributor Author

kudep commented Jul 23, 2020

Does add_bot_utterance_last_chance_overwrite need to be updated too?

@yurakuratov
Copy link

yurakuratov commented Jul 23, 2020 •
edited
Loading

Does add_bot_utterance_last_chance_overwrite need to be updated too?

I'm not sure what is a use-case for this method.
Also, I am not sure if these lines https://github.com/deepmipt/dp-agent/blob/master/deeppavlov_agent/core/state_manager.py#L80-L84 should be inside of if statement.
Or these lines https://github.com/deepmipt/dp-agent/blob/master/deeppavlov_agent/core/state_manager.py#L89-L93 should be out of if statement.

@p-rdx can you help us?

@p-rdx
Copy link
Collaborator

p-rdx commented Jul 24, 2020

Actually both of them. Otherwise if some of the formatters requires original text from the previous bot utterance, they will fail.

@IgnatovFedor IgnatovFedor merged commit f84f102 into dev Jul 30, 2020
@kudep kudep mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnatovFedor IgnatovFedor IgnatovFedor approved these changes

Assignees

@kudep kudep

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

field orig_text is empty
4 participants
@kudep @yurakuratov @p-rdx @IgnatovFedor